Improve deps #431
Merged
Improve deps #431
+215
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Itxaka
commented
Feb 18, 2025
Itxaka
commented
- Bump some of the generic deps
- Add the GetSecureBoot method so we can drop the efi dep
- Remove earthly stuff
- Bump some of the generic deps - Add the GetSecureBoot method so we can drop the efi dep - Remove earthly stuff Signed-off-by: Itxaka <[email protected]>
Itxaka
commented
Feb 18, 2025
|
|
||
| require ( | ||
| github.com/avast/retry-go v3.0.0+incompatible | ||
| github.com/containerd/containerd v1.7.25 |
There was a problem hiding this comment.
this was just moved from below into the main require as we had 2 require stanzas for some reason
Itxaka
commented
Feb 18, 2025
| github.com/gofrs/uuid v4.4.0+incompatible | ||
| github.com/google/go-tpm v0.9.3 |
Signed-off-by: Itxaka <[email protected]>
Itxaka
commented
Feb 18, 2025
| @@ -348,3 +350,31 @@ func Copy(src, dst string) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // GetSecureboot checks if secureboot is enabled in the system by checking the expected efivar | |||
| func GetSecureboot() bool { | |||
There was a problem hiding this comment.
Manually checking the Efivar for Secureboot support saves us from depending on go-uefi. we only used this part and checking a single efi var is simple
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 12.13% 11.98% -0.16%
==========================================
Files 11 11
Lines 1804 1828 +24
==========================================
Hits 219 219
- Misses 1568 1592 +24
Partials 17 17 ☔ View full report in Codecov by Sentry. |
jimmykarily
reviewed
Feb 20, 2025
| @@ -12,7 +12,6 @@ import ( | |||
| "syscall" | |||
| "time" | |||
|
|
|||
| "github.com/foxboron/go-uefi/efi" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.